xuyangzhong commented on code in PR #25565:
URL: https://github.com/apache/flink/pull/25565#discussion_r1905002294
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/typeutils/LegacyDataViewUtils.scala:
##########
@@ -200,12 +199,7 @@ object LegacyDataViewUtils {
case _ =>
instance.asInstanceOf[ListView[_]]
}
- val newTypeInfo = if (listView != null && listView.elementType !=
null) {
- // use explicit element type if user has defined
- new ListViewTypeInfo(listView.elementType)
- } else {
- list
- }
+ val newTypeInfo = list
Review Comment:
Nit: It seems that `listView` can also be removed, and the variable
`newTypeInfo` is not needed either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
