lvyanquan commented on code in PR #3668:
URL: https://github.com/apache/flink-cdc/pull/3668#discussion_r1904119776
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/RecordUtils.java:
##########
@@ -384,6 +390,40 @@ public static TableId getTableId(SourceRecord dataRecord) {
return new TableId(dbName, null, tableName);
}
+ public static SourceRecord setTableId(
+ SourceRecord dataRecord, TableId originalTableId, TableId tableId)
{
Review Comment:
We can move the logic of isOnLineSchemaChangeEvent and setTableId to
[MySqlStreamingChangeEventSource#handleQueryEvent](https://github.com/apache/flink-cdc/blob/ddb5f00df5bab21e8c91e4a31574d446d8b7a3f7/flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/io/debezium/connector/mysql/MySqlStreamingChangeEventSource.java#L660)
to simplify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
