afedulov commented on code in PR #25656:
URL: https://github.com/apache/flink/pull/25656#discussion_r1898961847
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -1029,6 +1029,11 @@ private TableResultInternal executeInternal(
defaultJobName,
jobStatusHookList);
try {
+ // Current context class loader here is the application class
loader.
Review Comment:
@ammu20-dev my concern is that 1.19 is a released version and we need to be
extra careful not to break existing functionality when users do a patch version
upgrade. As for CI, do you know of a concrete test that specifically verifies
what I mentioned as my main concern, i.e. that the classes shipped inside of
the user JARs for non-shaded libraries, which might also happen to be used by
the serializers and formats, won't get overloaded with a potentially different
dependency version and break binary compatibility? If there are no such
explicit tests, the green CI might be a false negative.
Just to be clear - 2.0 can introduce breaking changes. 1.19.x can't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
