xuyangzhong commented on code in PR #25595:
URL: https://github.com/apache/flink/pull/25595#discussion_r1900576756


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java:
##########
@@ -1827,18 +1827,8 @@ public static boolean isHiveTable(Map<String, String> 
properties) {
 
     @Internal
     public static boolean isHiveTable(Table table) {
-        boolean isHiveTable;
-        if 
(table.getParameters().containsKey(CatalogPropertiesUtil.IS_GENERIC)) {

Review Comment:
   I'm curious why we need to modify some logic related to Hive tables. It 
seems unrelated to the removal of CatalogFunction#isGeneric.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to