xuyangzhong commented on code in PR #25717:
URL: https://github.com/apache/flink/pull/25717#discussion_r1900519913
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecRank.java:
##########
@@ -250,17 +257,31 @@ protected Transformation<RowData> translateToPlanInternal(
generateUpdateBefore,
outputRankNumber);
} else if (RankUtil.isTop1(rankRange)) {
- processFunction =
- new FastTop1Function(
- ttlConfig,
- inputRowTypeInfo,
- sortKeyComparator,
- sortKeySelector,
- rankType,
- rankRange,
- generateUpdateBefore,
- outputRankNumber,
- cacheSize);
+ if (enableAsyncState) {
Review Comment:
I was trying to use a `RankOperatorBuilder` in table-runtime module like
`WindowAggOperatorBuilder` before. However, some classes in table-planner need
to be moved to table-runtime to adapt this change(such as SortSpec,
RankProcessStrategy and etc).
I want to do this independent improvement in a new jira to avoid introducing
many irrelevant changes in this jira. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
