XComp opened a new pull request, #25868:
URL: https://github.com/apache/flink/pull/25868
## What is the purpose of the change
I still cannot fully explain why the `ForkJoinPool` causes issues. But we've
seen a failure in
`CheckpointResourcesCleanupRunnerTest#testCloseAsyncAfterStartAndErrorInCompletedCheckpointStoreShutdown`
in a Flink fork where a thread got leaked and the run timed out.
The reasoning is here that the `ForkJoinPool` is a resource that's used by
JUnit for parallel test execution and in this regard might be subject to
unexpected shutdown behavior. Instead, we should switch to the
`TestExecutorExtension` as we're doing in all the other tests to have
independent resource lifecycle handling.
## Brief change log
* Replaces `ForkJoinPool` with `TestExecutorExtension`
## Verifying this change
* Test code is still succeeded
* Error wasn't reproducible
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
