snuyanzin commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1893952530
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##########
@@ -804,4 +813,163 @@ private Stream<TestSetSpec> floorTestCases() {
.format(TIMESTAMP_FORMATTER),
STRING().nullable()));
}
+
+ private Stream<TestSetSpec> toTimestampLtzTestCases() {
+ return Stream.of(
+
TestSetSpec.forFunction(BuiltInFunctionDefinitions.TO_TIMESTAMP_LTZ)
+ .onFieldsWithData(
+ 100,
+ 1234,
+ -100,
+ null,
+ DecimalDataUtils.castFrom(-Double.MAX_VALUE,
38, 18),
Review Comment:
I don't see here tests for invalid input
like invalid timezone, invalid format
invalid something else...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
