Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2939#discussion_r91722459
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/classloading/jar/CheckpointedStreamingProgram.java
 ---
    @@ -57,7 +59,7 @@ public static void main(String[] args) throws Exception {
     
     
        // with Checkpoining
    -   public static class SimpleStringGenerator implements 
SourceFunction<String>, Checkpointed<Integer> {
    --- End diff --
    
    I understand why you did not replace ´Checkpointed` with a different 
interface, but this technically changes the test. If a function can still 
implement these interfaces without doing anything within snapshot/restore, then 
we should cover this with tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to