[PR] [FLINK-36227] Restore compatibility with Logback 1.2 [flink]

[via GitHub]

piotrp opened a new pull request, #25813:
URL: https://github.com/apache/flink/pull/25813

   ## What is the purpose of the change
   
   Restores compatibility with Logback 1.2, fixes issues 
[FLINK-36104](https://issues.apache.org/jira/browse/FLINK-36104) and 
[FLINK-36227](https://issues.apache.org/jira/browse/FLINK-36227).
   
   Master branch still uses SLF4J 1.7 so this PR should target both master and 
Flink 1.20.
   
   ## Verifying this change
   
   Not feasible to do in an automated manner because it depends global MDC 
implementation picked up by SLF4J. Tested manually by adding a new test to 
`MdcUtilsTest`:
   
   ```java
       @Test
       void testContextResetWorksWithNullContext() {
           MDC.clear();
           assertThat(MDC.getCopyOfContextMap()).isNull();
           MdcCloseable restoreContext = 
MdcUtils.withContext(Collections.emptyMap());
           assertDoesNotThrow(restoreContext::close);
       }
   ```
   
   and changing flink-core/pom.xml to use Logback:
   
   ```xml
                <dependency>
                        <groupId>org.apache.flink</groupId>
                        <artifactId>flink-test-utils-junit</artifactId>
                        <exclusions>
                                <exclusion>
                                        
<groupId>org.apache.logging.log4j</groupId>
                                        <artifactId>*</artifactId>
                                </exclusion>
                                <exclusion>
                                        
<groupId>org.apache.logging.log4j</groupId>
                                        <artifactId>*</artifactId>
                                </exclusion>
                        </exclusions>
                </dependency>
   
                <dependency>
                        <groupId>ch.qos.logback</groupId>
                        <artifactId>logback-classic</artifactId>
                        <version>1.2.13</version>
                        <scope>test</scope>
                </dependency>
   
                <dependency>
                        <groupId>ch.qos.logback</groupId>
                        <artifactId>logback-classic</artifactId>
                        <version>1.2.13</version>
                        <scope>test</scope>
                </dependency>
   ```
   
   Test failed before change from this PR, and passed after.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org