RocMarshal commented on code in PR #25800: URL: https://github.com/apache/flink/pull/25800#discussion_r1888725463
########## flink-core/src/test/java/org/apache/flink/configuration/TaskManagerLoadBalanceModeTest.java: ########## @@ -1,49 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.flink.configuration; - -import org.junit.jupiter.api.Test; - -import static org.apache.flink.configuration.TaskManagerOptions.TASK_MANAGER_LOAD_BALANCE_MODE; -import static org.apache.flink.configuration.TaskManagerOptions.TaskManagerLoadBalanceMode; -import static org.assertj.core.api.Assertions.assertThat; - -/** Test for {@link TaskManagerLoadBalanceMode}. */ -class TaskManagerLoadBalanceModeTest { - - @Test - void testReadTaskManagerLoadBalanceMode() { Review Comment: thanks @davidradl for the comments. Please let me clarify the background fo the testing class. The test was initially introduced to verify whether the new configuration method is compatible with the old one. Since the old configuration method has now been removed, the logic for determining the value of the current configuration item has become much simpler and more straightforward. In other words, continuing to keep this test case would be somewhat redundant. WDYTA? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
