yuchen-ecnu commented on code in PR #25798:
URL: https://github.com/apache/flink/pull/25798#discussion_r1887177186
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java:
##########
@@ -101,6 +102,8 @@ void enableCheckpointing(
void setJsonPlan(String jsonPlan);
+ void setJsonStreamGraph(JsonStreamGraph jsonStreamGraph);
Review Comment:
Great tips! `ExecutionPlanSchedulingContext` really helps a lot. I have
remove the unexpected `setJsonStreamGraph` methods from `ExecutionGraph` in the
revised version.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/execution/ExecutionState.java:
##########
@@ -70,6 +70,8 @@ public enum ExecutionState {
RECONCILING,
+ PENDING,
Review Comment:
Agree with you. Since it’s not a valid status for stream jobs, how about
including it in the serialized JSON stream graph
(`JsonPlanGenerator#generateJsonStreamGraph`)? This would help avoid adding
interfaces like `getPendingOperatorCounts()` to the `ExecutionGraph` and
`ArchivedExecutionGraph` for processing in
`JobDetailsHandler#createJobDetailsInfo`. And it will be processed in frontend
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
