snuyanzin commented on code in PR #25759: URL: https://github.com/apache/flink/pull/25759#discussion_r1883856179
########## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ########## @@ -439,8 +441,9 @@ private Stream<TestSetSpec> ceilTestCases() { // Fractional seconds are lost LocalTime.of(11, 22, 33), LocalDate.of(1990, 10, 14), - LocalDateTime.of(2020, 2, 29, 1, 56, 59, 987654321)) - .andDataTypes(TIME(), DATE(), TIMESTAMP()) + LocalDateTime.of(2020, 2, 29, 1, 56, 59, 987654321), + LocalDateTime.of(2020, 2, 29, 1, 56, 57, 924325471)) Review Comment: what is the reason to keep 2 localdatatimes here? I'm asking since now it is tricky to realize which of them is used and where -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org