MOBIN-F commented on code in PR #3791: URL: https://github.com/apache/flink-cdc/pull/3791#discussion_r1879258925
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/main/java/org/apache/flink/cdc/connectors/kafka/json/debezium/DebeziumJsonRowDataSerializationSchema.java: ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cdc.connectors.kafka.json.debezium; + +import org.apache.flink.api.common.serialization.SerializationSchema; +import org.apache.flink.formats.common.TimestampFormat; +import org.apache.flink.formats.json.JsonFormatOptions; +import org.apache.flink.formats.json.JsonParserRowDataDeserializationSchema; +import org.apache.flink.formats.json.JsonRowDataDeserializationSchema; +import org.apache.flink.formats.json.RowDataToJsonConverters; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.util.jackson.JacksonMapperFactory; + +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonGenerator; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.node.ObjectNode; + +import java.util.Objects; + +/** + * Serialization schema that serializes an object of Flink internal data structure into a JSON + * bytes. + * + * <p>Serializes the input Flink object into a JSON string and converts it into <code>byte[]</code>. + * + * <p>Result <code>byte[]</code> messages can be deserialized using {@link + * JsonRowDataDeserializationSchema} or {@link JsonParserRowDataDeserializationSchema}. + */ +public class DebeziumJsonRowDataSerializationSchema implements SerializationSchema<RowData> { + private static final long serialVersionUID = 1L; + + /** RowType to generate the runtime converter. */ + private final RowType rowType; + + /** The converter that converts internal data formats to JsonNode. */ + private final RowDataToJsonConverters.RowDataToJsonConverter runtimeConverter; + + /** Object mapper that is used to create output JSON objects. */ + private transient ObjectMapper mapper; + + /** Reusable object node. */ + private transient ObjectNode node; + + /** Timestamp format specification which is used to parse timestamp. */ + private final TimestampFormat timestampFormat; + + /** The handling mode when serializing null keys for map data. */ + private final JsonFormatOptions.MapNullKeyMode mapNullKeyMode; + + /** The string literal when handling mode for map null key LITERAL. */ + private final String mapNullKeyLiteral; + + /** Flag indicating whether to serialize all decimals as plain numbers. */ + private final boolean encodeDecimalAsPlainNumber; + + private final boolean includeSchemaInfo; + + public DebeziumJsonRowDataSerializationSchema( + RowType rowType, + TimestampFormat timestampFormat, + JsonFormatOptions.MapNullKeyMode mapNullKeyMode, + String mapNullKeyLiteral, + boolean encodeDecimalAsPlainNumber, + boolean includeSchemaInfo) { + this.rowType = rowType; + this.timestampFormat = timestampFormat; + this.mapNullKeyMode = mapNullKeyMode; + this.mapNullKeyLiteral = mapNullKeyLiteral; + this.encodeDecimalAsPlainNumber = encodeDecimalAsPlainNumber; + this.runtimeConverter = + new RowDataToJsonConverters(timestampFormat, mapNullKeyMode, mapNullKeyLiteral) + .createConverter(rowType); + this.includeSchemaInfo = includeSchemaInfo; + } + + @Override + public void open(InitializationContext context) throws Exception { + mapper = + JacksonMapperFactory.createObjectMapper() + .configure( + JsonGenerator.Feature.WRITE_BIGDECIMAL_AS_PLAIN, + encodeDecimalAsPlainNumber); + } + + @Override + public byte[] serialize(RowData row) { + if (node == null) { + node = mapper.createObjectNode(); + } + + try { + runtimeConverter.convert(mapper, node, row); + if (includeSchemaInfo) { + // schema is a nested json string, asText() can return a pure string without other + // escape characters such as "\" + String schemaValue = node.get("schema").asText(); + JsonNode schemaNode = mapper.readTree(schemaValue); + node.set("schema", schemaNode); Review Comment: Because the schema is passed to the downstream as a string, and there is a nested json in the schema, if the json string is put into jsonNode, there will be [\"]. The JsonNode.asText() method can solve this problem well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
