dawidwys commented on code in PR #25779:
URL: https://github.com/apache/flink/pull/25779#discussion_r1878242463
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.java:
##########
@@ -149,12 +157,129 @@ void testResolvingProctimeOfCustomTableTableApi() throws
Exception {
testUtil.verifyExecPlan(table);
}
+ @TestTemplate
+ void testTimeAttributeOfView() {
+ if (!streamingMode) {
+ // time attributes not supported in batch
+ return;
Review Comment:
The test does not make any sense in non streaming mode. Batch does not deal
with time attributes the way streaming does. Nothing fails here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
