Laffery commented on code in PR #25713:
URL: https://github.com/apache/flink/pull/25713#discussion_r1865165269
##########
flink-runtime-web/pom.xml:
##########
@@ -263,8 +263,8 @@ under the License.
<goal>install-node-and-npm</goal>
</goals>
<configuration>
-
<nodeVersion>v16.13.2</nodeVersion>
-
<npmVersion>8.1.2</npmVersion>
+
<nodeVersion>v18.19.1</nodeVersion>
Review Comment:
Maintenance of node.js v18 LTS will end in May 2025, what about using v20
LTS directly?
##########
flink-runtime-web/web-dashboard/src/main.ts:
##########
@@ -80,13 +80,9 @@ bootstrapApplication(AppComponent, {
deps: [StatusService, Injector],
multi: true
},
- importProvidersFrom(HttpClientModule),
+ provideHttpClient(withInterceptorsFromDi()),
importProvidersFrom(BrowserAnimationsModule),
Review Comment:
use `provideNzI18n()` `provideNzConfig(ngZorroConfig)`
`provideNzIcons(APP_ICONS)` `provideAnimationsAsync()` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
