yuxiqian commented on code in PR #3763:
URL: https://github.com/apache/flink-cdc/pull/3763#discussion_r1861478089
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/test/java/org/apache/flink/cdc/connectors/base/source/assigner/state/PendingSplitsStateSerializerTest.java:
##########
@@ -152,7 +152,7 @@ public Offset createNoStoppingOffset() {
private SchemalessSnapshotSplit constuctSchemalessSnapshotSplit() {
return new SchemalessSnapshotSplit(
tableId,
- "test",
+ tableId.toString() + ":0",
Review Comment:
Is is possible to make it `@VisibleForTesting` and call `generateSplitId`,
to reduce potential discrepancy?
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/assigners/state/PendingSplitsStateSerializerTest.java:
##########
@@ -190,7 +190,7 @@ private static MySqlSchemalessSnapshotSplit
getTestSchemalessSnapshotSplit(
TableId tableId, int splitNo) {
return new MySqlSchemalessSnapshotSplit(
tableId,
- tableId.toString() + "-" + splitNo,
+ tableId.toString() + ":" + splitNo,
Review Comment:
Ditto
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/SnapshotSplit.java:
##########
@@ -95,6 +125,18 @@ public final SchemalessSnapshotSplit
toSchemalessSnapshotSplit() {
tableId, splitId, splitKeyType, splitStart, splitEnd,
highWatermark);
}
+ private static String generateSplitId(TableId tableId, int chunkId) {
+ return tableId.toString() + ":" + chunkId;
+ }
+
+ public static TableId parseTableId(String splitId) {
Review Comment:
Will `extract` be a more precise name than `parse`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
