Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2963#discussion_r91532008
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BarrierBuffer.java
 ---
    @@ -422,7 +425,7 @@ private void beginNewAlignment(long checkpointId, int 
channelIndex) throws IOExc
                startOfAlignmentTimestamp = System.nanoTime();
     
                if (LOG.isDebugEnabled()) {
    -                   LOG.debug("Starting stream alignment for checkpoint " + 
checkpointId);
    +                   LOG.debug("Starting stream alignment for checkpoint 
{}.", checkpointId);
    --- End diff --
    
    I am not a super big fan of that change: Given that this is guarded by a 
`LOG.isDebugEnabled()` the prior version was actually more efficient than the 
new one. Saves a boxing operation and a parsing step.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to