AHeise commented on code in PR #25685:
URL: https://github.com/apache/flink/pull/25685#discussion_r1860251139
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/translators/GlobalCommitterTransformationTranslator.java:
##########
@@ -90,7 +92,18 @@ private Collection<Integer> translateInternal(
transformation.setName(GLOBAL_COMMITTER_TRANSFORMATION_NAME);
transformation.setParallelism(1);
transformation.setMaxParallelism(1);
- return Collections.emptyList();
+ copySafely(transformation::setName, globalCommitterTransform::getName);
Review Comment:
We set the attributes while expanding the post commit topology. We expand
this transform almost at the end of the sink expansion. So it's fair to say
that we have it in all cases where we set the properties during post commit
expansion. It's not set if no uid or customUidHashes are user-supplied. I think
name should always be set but I still use the copySafely method because you
never know how things will evolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
