davidradl commented on code in PR #25647:
URL: https://github.com/apache/flink/pull/25647#discussion_r1851640555
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocatorFactory.java:
##########
@@ -40,13 +41,16 @@ public SlotSharingExecutionSlotAllocatorFactory(
PhysicalSlotProvider slotProvider,
boolean slotWillBeOccupiedIndefinitely,
PhysicalSlotRequestBulkChecker bulkChecker,
- Duration allocationTimeout) {
+ Duration allocationTimeout,
+ TaskManagerOptions.TaskManagerLoadBalanceMode
taskManagerLoadBalanceMode) {
this(
slotProvider,
slotWillBeOccupiedIndefinitely,
bulkChecker,
allocationTimeout,
- new LocalInputPreferredSlotSharingStrategy.Factory());
+ taskManagerLoadBalanceMode ==
TaskManagerOptions.TaskManagerLoadBalanceMode.TASKS
+ ? new
TaskBalancedPreferredSlotSharingStrategy.Factory()
Review Comment:
I see that specifying TASKS means this factory will be used to load balance.
I do not see the works task number in the factory implementation. It seems to
be trying to colocate tasks in a slot. I am not sure when this would be
preferable or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
