lvyanquan commented on code in PR #25667:
URL: https://github.com/apache/flink/pull/25667#discussion_r1850103994
##########
docs/content/docs/dev/datastream/sources.md:
##########
@@ -325,16 +325,13 @@ public class FixedFetcherSizeSourceReader<E, T, SplitT
extends SourceSplit, Spli
extends SourceReaderBase<E, T, SplitT, SplitStateT> {
public FixedFetcherSizeSourceReader(
- FutureCompletingBlockingQueue<RecordsWithSplitIds<E>>
elementsQueue,
Supplier<SplitReader<E, SplitT>> splitFetcherSupplier,
RecordEmitter<E, T, SplitStateT> recordEmitter,
Configuration config,
SourceReaderContext context) {
super(
- elementsQueue,
new FixedSizeSplitFetcherManager<>(
- config.getInteger(SourceConfig.NUM_FETCHERS),
- elementsQueue,
+ config.get(SourceConfig.NUM_FETCHERS),
splitFetcherSupplier),
Review Comment:
The construction method of FixedSizeSplitFetcherManager is
```
public FixedSizeSplitFetcherManager(
int numFetchers,
Supplier<SplitReader<E, SplitT>> splitReaderSupplier,
Configuration config)
```
but here you created it with
```
new FixedSizeSplitFetcherManager<>(
config.get(SourceConfig.NUM_FETCHERS),
splitFetcherSupplier)
```
config should be passed to construction method too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
