huyuanfeng2018 commented on code in PR #904:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/904#discussion_r1846250291
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ParallelismAdjuster.java:
##########
@@ -100,4 +109,28 @@ private static int calculateMinimumParallelism(
p = Math.max(p, parallelismLowerLimit);
return p;
}
+
+ /** The mode of the key group or parallelism adjustment. */
+ public enum KeyGroupOrPartitionsAdjustMode implements DescribedEnum {
+ ABSOLUTELY_EVENLY_DISTRIBUTION(
Review Comment:
> The name is confusing because this doesn't guarantee absolutely even
distribution.
>
> How about `EVENLY_SPREAD`?
Looks like `EVENLY_SPREAD` is more reasonable, I'm fine with that
@1996fanrui What do you think about this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
