yuxiqian commented on code in PR #3660:
URL: https://github.com/apache/flink-cdc/pull/3660#discussion_r1845804885
##########
.github/workflows/flink_cdc.yml:
##########
Review Comment:
Please also remove Flink 1.18 tests in `flink_cdc_migration_test.yml`
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/pom.xml:
##########
@@ -28,7 +28,7 @@ limitations under the License.
<artifactId>flink-cdc-pipeline-connector-starrocks</artifactId>
<properties>
-
<starrocks.connector.version>1.2.9_flink-${flink.major.version}</starrocks.connector.version>
+
<starrocks.connector.version>1.2.9_flink-1.18</starrocks.connector.version>
Review Comment:
It should be safe to upgrade to 1.2.10 with `flink-1.19` support.
(Some workarounds for `1.2.9_flink-1.18` could be removed, too.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
