tinaselenge commented on code in PR #25579:
URL: https://github.com/apache/flink/pull/25579#discussion_r1843739058
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java:
##########
@@ -486,48 +486,41 @@ public static Catalog createCatalog(
Map<String, String> options,
ReadableConfig configuration,
ClassLoader classLoader) {
- // Use the legacy mechanism first for compatibility
- try {
- final CatalogFactory legacyFactory =
- TableFactoryService.find(CatalogFactory.class, options,
classLoader);
- return legacyFactory.createCatalog(catalogName, options);
- } catch (NoMatchingTableFactoryException e) {
- // No matching legacy factory found, try using the new stack
+ // No matching legacy factory found, try using the new stack
Review Comment:
Do we still need this comment since we are no longer checking if legacy
factory is found?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
