pawel-big-lebowski commented on code in PR #130:
URL:
https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1843705755
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilder.java:
##########
@@ -369,5 +420,46 @@ public ProducerRecord<byte[], byte[]> serialize(
value,
headerProvider != null ?
headerProvider.getHeaders(element) : null);
}
+
+ @Override
+ public Optional<KafkaDatasetFacet> getKafkaDatasetFacet() {
+ if (!(topicSelector instanceof KafkaDatasetIdentifierProvider)) {
+ LOG.info("Cannot identify topics. Not an
TopicsIdentifierProvider");
+ return Optional.empty();
+ }
+
+ Optional<DefaultKafkaDatasetIdentifier> topicsIdentifier =
+ ((KafkaDatasetIdentifierProvider)
(topicSelector)).getDatasetIdentifier();
+
+ if (!topicsIdentifier.isPresent()) {
+ LOG.info("No topics' identifiers provided");
+ return Optional.empty();
+ }
+
+ return Optional.of(new
DefaultKafkaDatasetFacet(topicsIdentifier.get()));
+ }
+
+ @Override
+ public Optional<TypeDatasetFacet> getTypeDatasetFacet() {
+ if (this.valueSerializationSchema instanceof ResultTypeQueryable) {
+ return Optional.of(
+ new DefaultTypeDatasetFacet(
+ ((ResultTypeQueryable<?>)
this.valueSerializationSchema)
+ .getProducedType()));
+ } else {
+ // gets type information from serialize method signature
+ TypeToken serializationSchemaType =
+ TypeToken.of(valueSerializationSchema.getClass());
+ Class parameterType =
+ serializationSchemaType
Review Comment:
You can avoid this with implementing `ResultTypeQueryable` of the value
serialisation schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
