davidradl commented on code in PR #25529:
URL: https://github.com/apache/flink/pull/25529#discussion_r1837761034
##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/StreamTableEnvironment.java:
##########
@@ -122,56 +118,6 @@ static StreamTableEnvironment create(
return StreamTableEnvironmentImpl.create(executionEnvironment,
settings);
}
- /**
- * Registers a {@link TableFunction} under a unique name in the
TableEnvironment's catalog.
- * Registered functions can be referenced in Table API and SQL queries.
- *
- * @param name The name under which the function is registered.
- * @param tableFunction The TableFunction to register.
- * @param <T> The type of the output row.
- * @deprecated Use {@link #createTemporarySystemFunction(String,
UserDefinedFunction)} instead.
- * Please note that the new method also uses the new type system and
reflective extraction
- * logic. It might be necessary to update the function implementation
as well. See the
- * documentation of {@link TableFunction} for more information on the
new function design.
- */
- @Deprecated
- <T> void registerFunction(String name, TableFunction<T> tableFunction);
Review Comment:
I see this referred to in the Python code
` self._j_tenv.registerFunction(name, java_function)`
I think these references need to be removed also if this java function is
being removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
