yuxiqian commented on code in PR #3572:
URL: https://github.com/apache/flink-cdc/pull/3572#discussion_r1836241798
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PreTransformOperator.java:
##########
@@ -386,37 +436,16 @@ private Schema transformSchemaMetaData(
return schemaBuilder.build();
}
- private DataChangeEvent processDataChangeEvent(DataChangeEvent
dataChangeEvent)
- throws Exception {
- TableId tableId = dataChangeEvent.tableId();
- for (PreTransformer transform : transforms) {
- Selectors selectors = transform.getSelectors();
-
- if (selectors.isMatch(tableId) &&
transform.getProjection().isPresent()) {
- TransformProjection transformProjection =
transform.getProjection().get();
- TransformFilter transformFilter =
transform.getFilter().orElse(null);
- if (transformProjection.isValid()) {
- return processProjection(transformProjection,
transformFilter, dataChangeEvent);
- }
- }
+ private DataChangeEvent processDataChangeEvent(DataChangeEvent
dataChangeEvent) {
+ if (!transforms.isEmpty()) {
+ return processProjection(dataChangeEvent);
}
return dataChangeEvent;
}
Review Comment:
Seems the logic is too simple and not worth being an independent method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
