[
https://issues.apache.org/jira/browse/FLINK-36622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895168#comment-17895168
]
Zakelly Lan commented on FLINK-36622:
-------------------------------------
Merge fde0c29 into flink-benchmarks
> Remove the dependency of StateBenchmark on RocksDBKeyedStateBackend APIs.
> -------------------------------------------------------------------------
>
> Key: FLINK-36622
> URL: https://issues.apache.org/jira/browse/FLINK-36622
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / State Backends
> Reporter: Han Yin
> Assignee: Han Yin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.0.0
>
>
> Currently, flink-benchmarks relies on non-public APIs in Flink. For example,
> in {_}+StateBackendBenchmarkUtils.java+{_}, the function _+compactState+_
> takes RocksDBKeyedStateBackend as its first argument.
> This requires explicit type conversion in flink-benchmark(from
> +_KeyedStateBackend_+ to {+}_RocksDBKeyedStateBackend_{+}). Moreover, this
> means that once the signature of +_RocksDBKeyedStateBackend_+ changes, we
> need to modify flink-benchmark correspondingly.
> Therefore, we should avoid exposing non-public APIs in
> {_}+StateBackendBenchmarkUtils+{_}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
