vahmed-hamdy commented on code in PR #110: URL: https://github.com/apache/flink-connector-elasticsearch/pull/110#discussion_r1826998011
########## .github/workflows/push_pr.yml: ########## @@ -28,13 +28,8 @@ jobs: compile_and_test: strategy: matrix: - flink: [ 1.18-SNAPSHOT ] Review Comment: I think it is not mandatory unless we are removing support to the v3.0 branch as explained in the [bylaws](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=231116690#ExternalizedConnectordevelopment-Support) which also couldn't happen until the next connector release. The ideal case would be to keep the compatibility guarantee with 1.19 as mentioned however I would prefer dropping 1.18 in either cases, wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org