noorall commented on code in PR #25414: URL: https://github.com/apache/flink/pull/25414#discussion_r1816403718
########## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/util/StreamEdgeUpdateRequestInfo.java: ########## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.graph.util; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.streaming.runtime.partitioner.StreamPartitioner; + +/** + * This class implements the {@link StreamGraphUpdateRequestInfo} interface and carries the data + * required to updates a stream edge. + */ +@Internal +public class StreamEdgeUpdateRequestInfo implements StreamGraphUpdateRequestInfo { + private final String edgeId; + private final Integer sourceId; + private final Integer targetId; + + private StreamPartitioner<?> outputPartitioner; + + public StreamEdgeUpdateRequestInfo(String edgeId, Integer sourceId, Integer targetId) { + this.edgeId = edgeId; Review Comment: > I think sourceId and targetId are enough. The related changes can also be removed. It is not enough to identify a unique stream edge solely by sourceId and targetId. For example, in a custom operator, a user can specify a source operator to have multiple identical edges pointing to the same target operator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
