xiangyuf commented on code in PR #25554: URL: https://github.com/apache/flink/pull/25554#discussion_r1816190153
########## flink-runtime/src/main/java/org/apache/flink/runtime/state/ttl/TtlAwareSerializer.java: ########## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.ttl; + +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot; +import org.apache.flink.api.common.typeutils.base.ListSerializer; +import org.apache.flink.api.common.typeutils.base.MapSerializer; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.util.function.SupplierWithException; + +import java.io.IOException; +import java.util.Objects; + +/** Serializer to wrap a {@link TypeSerializer} with TTL awareness. */ +public class TtlAwareSerializer<T> extends TypeSerializer<T> { + + private final boolean isTtlEnabled; + + private final TypeSerializer<T> typeSerializer; + + public TtlAwareSerializer(TypeSerializer<T> typeSerializer) { + this.typeSerializer = typeSerializer; + this.isTtlEnabled = typeSerializer instanceof TtlStateFactory.TtlSerializer; + } + + @Override + public boolean isImmutableType() { + return typeSerializer.isImmutableType(); + } + + @Override + public TypeSerializer<T> duplicate() { + return new TtlAwareSerializer<>(typeSerializer.duplicate()); + } + + @Override + public T createInstance() { + return typeSerializer.createInstance(); + } + + @Override + public T copy(T from) { + return typeSerializer.copy(from); + } + + @Override + public T copy(T from, T reuse) { + return typeSerializer.copy(from, reuse); + } + + @Override + public int getLength() { + return typeSerializer.getLength(); + } + + @Override + public void serialize(T record, DataOutputView target) throws IOException { + typeSerializer.serialize(record, target); + } + + @Override + public T deserialize(DataInputView source) throws IOException { + return typeSerializer.deserialize(source); + } + + @Override + public T deserialize(T reuse, DataInputView source) throws IOException { + return typeSerializer.deserialize(reuse, source); + } + + @Override + public boolean equals(Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + TtlAwareSerializer<?> that = (TtlAwareSerializer<?>) o; + return isTtlEnabled == that.isTtlEnabled + && Objects.equals(typeSerializer, that.typeSerializer); + } + + @Override + public int hashCode() { + return Objects.hash(isTtlEnabled, typeSerializer); + } + + @SuppressWarnings("unchecked") + public void migrateValueFromPriorSerializer( + TtlAwareSerializer<T> priorTtlAwareSerializer, + SupplierWithException<T, IOException> inputSupplier, + DataOutputView target, + TtlTimeProvider ttlTimeProvider) + throws IOException { + T outputRecord; + if (this.isTtlEnabled()) { + outputRecord = + priorTtlAwareSerializer.isTtlEnabled + ? inputSupplier.get() + : (T) + new TtlValue<>( + inputSupplier.get(), + ttlTimeProvider.currentTimestamp()); + } else { + outputRecord = + priorTtlAwareSerializer.isTtlEnabled + ? ((TtlValue<T>) inputSupplier.get()).getUserValue() + : inputSupplier.get(); + } + this.serialize(outputRecord, target); + } + + @Override + public void copy(DataInputView source, DataOutputView target) throws IOException { + typeSerializer.copy(source, target); + } + + public boolean isTtlEnabled() { + return isTtlEnabled; + } + + public TypeSerializer<T> getOriginalTypeSerializer() { + return typeSerializer; + } + + @Override + public TypeSerializerSnapshot<T> snapshotConfiguration() { + return new TtlAwareSerializerSnapshot<>( + typeSerializer.snapshotConfiguration(), isTtlEnabled); + } + + @SuppressWarnings("rawtypes") + public static boolean isSerializerTtlEnabled(TypeSerializer<?> typeSerializer) { + TypeSerializer wrappedTypeSerializer = wrapTtlAwareSerializer(typeSerializer); + boolean ttlSerializer = + wrappedTypeSerializer instanceof TtlAwareSerializer + && ((TtlAwareSerializer) wrappedTypeSerializer).isTtlEnabled(); + boolean ttlListSerializer = + wrappedTypeSerializer instanceof ListSerializer + && ((ListSerializer) wrappedTypeSerializer).getElementSerializer() + instanceof TtlAwareSerializer + && ((TtlAwareSerializer) + ((ListSerializer) wrappedTypeSerializer) + .getElementSerializer()) + .isTtlEnabled(); + boolean ttlMapSerializer = + wrappedTypeSerializer instanceof MapSerializer + && ((MapSerializer) wrappedTypeSerializer).getValueSerializer() + instanceof TtlAwareSerializer + && ((TtlAwareSerializer) + ((MapSerializer) wrappedTypeSerializer) + .getValueSerializer()) + .isTtlEnabled(); + return ttlSerializer || ttlListSerializer || ttlMapSerializer; + } + + public static TypeSerializer<?> wrapTtlAwareSerializer(TypeSerializer<?> typeSerializer) { Review Comment: @Zakelly For ListSerializer/MapSerializer, the return type is not TtlAwareSerializer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
