k-wall commented on PR #906: URL: https://github.com/apache/flink-kubernetes-operator/pull/906#issuecomment-2429777651
I think there is a misunderstand about the way that Maven profiles are activated. Maven profile can be activated by [system properties](https://maven.apache.org/guides/introduction/introduction-to-profiles.html#property), not maven properties. The two concepts are separate. So if the intent is that build activates `okhttp` by default, that's not happening. You can show this against main ``` mvn help:all-profiles | grep http Profile Id: depend-on-okhttp4 (Active: false , Source: pom) ``` ``` mvn help:all-profiles -Dfabric8.httpclient.impl=okhttp | grep http Profile Id: depend-on-okhttp4 (Active: true , Source: pom) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
