zhuzhurk commented on code in PR #25472:
URL: https://github.com/apache/flink/pull/25472#discussion_r1810402076
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java:
##########
@@ -393,9 +393,9 @@ private void
setBatchStateBackendAndTimerService(StreamGraph graph) {
if (useStateBackend) {
LOG.debug("Using BATCH execution state backend and timer
service.");
- graph.setStateBackend(new BatchExecutionStateBackend());
+ graph.setStateBackendAndCheckpointStorage(
+ new BatchExecutionStateBackend(), new
BatchExecutionCheckpointStorage());
Review Comment:
`createJobCheckpointingSettings()` should happen after setting
`ENABLE_STATE_CHANGE_LOG`.
I prefer to let the generator explicitly call
`createJobCheckpointingSettings()` in the end of
`setBatchStateBackendAndTimerService()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
