AHeise commented on PR #25456: URL: https://github.com/apache/flink/pull/25456#issuecomment-2421619618
> While I understand the idea of the change, I wonder if it the right time or way. > > We just cut 2.0 and this is potentially a breaking change since we do not control where users append the global committer in their sink topologies. It's very theoretical and the globalcommitter was marked `@Experimental` but we should at least discuss it. > > I am also a bit torn of the change of operation in the `GlobalCommitter` and the usage of the underlying infra structure i.e. `CheckpointCommittableManager`. I probably need another pass to fully understand how well the manager plays with the new semantics of the `GlobalCommitter`. As discussed offline. The cut was just for 2.0-preview and there is going to be another cut for the actual 2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
