[ 
https://issues.apache.org/jira/browse/FLINK-36551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890024#comment-17890024
 ] 

Keith Wall edited comment on FLINK-36551 at 10/16/24 10:34 AM:
---------------------------------------------------------------

I believe the intent of 
[docker-entry.sh#L88|https://github.com/apache/flink-kubernetes-operator/blob/d72e3ce294e3902cf041811e0fcf2ba50880cc31/tools/olm/docker-entry.sh#L88]
 is to overwrite the keystore volume provided from the Helm template so that 
the webhook can make use of 
 
[https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/building-your-csv.md#apiservice-serving-certs]

I think the issue is with the index into the volume array used by the yq 
command.  It assumes it is at index 1.    I think the yq expression needs to be 
smarter and compute the volume index it needs to replace.

 

All this code is new to me so I'd appreciate any comments telling me if I am on 
the right lines or not.

 

 

 


was (Author: k-wall):
I believe the intent of 
[docker-entry.sh#L88|https://github.com/apache/flink-kubernetes-operator/blob/d72e3ce294e3902cf041811e0fcf2ba50880cc31/tools/olm/docker-entry.sh#L88]
 is to overwrite the keystore volume provided from the Helm template so that 
the webhook can make use of 
 
[https://github.com/operator-framework/operator-lifecycle-manager/blob/master/doc/design/building-your-csv.md#apiservice-serving-certs]

I think the issue is with the index into the volume array used by the yq 
command.  It assumes it is at index 1.   

> Generated OLM bundle fails to deploy with install strategy failed .. 
> Duplicate value: "keystore"
> ------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-36551
>                 URL: https://issues.apache.org/jira/browse/FLINK-36551
>             Project: Flink
>          Issue Type: Bug
>          Components: Kubernetes Operator
>            Reporter: Keith Wall
>            Priority: Major
>
> I am using tools/olm/generate-olm-bundle.sh to create a fresh OLM bundle from 
> main.
> Working around FLINK-36544 (using the PR), I hit another problem after 
> creating the Subscription resource.  The CSV resource is looping, reporting 
> Failed.
> {{% oc get csv  -w}}
> {{NAME                                DISPLAY                     VERSION   
> REPLACES                           PHASE}}
> {{flink-kubernetes-operator.v1.10.0   Flink Kubernetes Operator   1.10.0    
> flink-kubernetes-operator.v1.2.0   Failed}}
> Examining the CSV resource, I can see a validation error in the status 
> section.
> {{ message: 'install strategy failed: Deployment.apps 
> "flink-kubernetes-operator" is invalid: [spec.template.spec.volumes[2].name: 
> Duplicate value: "keystore", 
> spec.template.spec.containers[0].volumeMounts[1].name: Not found: 
> "flink-artifacts-volume"]'}}
> The issue is that the deployment within the CSV does indeed have a duplicate 
> volume.
> docker_entry.sh creates a empty volume called keystore.
> [https://github.com/apache/flink-kubernetes-operator/blob/d72e3ce294e3902cf041811e0fcf2ba50880cc31/tools/olm/docker-entry.sh#L88]
> The template generated by Helm also creates a keystore volume (backed by the 
> secret).
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to