[ https://issues.apache.org/jira/browse/FLINK-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15725649#comment-15725649 ]
ASF GitHub Bot commented on FLINK-5041: --------------------------------------- Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2781#discussion_r91051952 --- Diff: flink-runtime/src/main/java/org/apache/flink/migration/runtime/checkpoint/savepoint/SavepointV0.java --- @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.migration.runtime.checkpoint.savepoint; + +import org.apache.flink.migration.runtime.checkpoint.TaskState; +import org.apache.flink.runtime.checkpoint.savepoint.Savepoint; +import org.apache.flink.util.Preconditions; + +import java.util.Collection; + +/** + * Savepoint version 0. + * + * <p>This format was introduced with Flink 1.1.0. + */ +public class SavepointV0 implements Savepoint { + + /** The savepoint version. */ + public static final int VERSION = 0; + + /** The checkpoint ID */ + private final long checkpointId; + + /** The task states */ + private final Collection<TaskState> taskStates; + + public SavepointV0(long checkpointId, Collection<TaskState> taskStates) { + this.checkpointId = checkpointId; + this.taskStates = Preconditions.checkNotNull(taskStates, "Task States"); + } + + @Override + public int getVersion() { + return VERSION; + } + + @Override + public long getCheckpointId() { + return checkpointId; + } + + @Override + public Collection<org.apache.flink.runtime.checkpoint.TaskState> getTaskStates() { + throw new UnsupportedOperationException(); + } + + @Override + public void dispose() throws Exception { + ClassLoader cl = Thread.currentThread().getContextClassLoader(); --- End diff -- Do we ever expect someone to use the `SavepointV0` to dispose state? If not, let's throw an `UnsupportedOperationException` here... > Implement savepoint backwards compatibility 1.1 -> 1.2 > ------------------------------------------------------ > > Key: FLINK-5041 > URL: https://issues.apache.org/jira/browse/FLINK-5041 > Project: Flink > Issue Type: New Feature > Components: State Backends, Checkpointing > Affects Versions: 1.2.0 > Reporter: Stefan Richter > Assignee: Stefan Richter > > This issue tracks the implementation of backwards compatibility between Flink > 1.1 and 1.2 releases. > This task subsumes: > - Converting old savepoints to new savepoints, including a conversion of > state handles to their new replacement. > - Converting keyed state from old backend implementations to their new > counterparts. > - Converting operator and function state for all changed operators. -- This message was sent by Atlassian JIRA (v6.3.4#6332)