fredia commented on code in PR #25501:
URL: https://github.com/apache/flink/pull/25501#discussion_r1798959007
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorStateHandler.java:
##########
@@ -244,6 +244,11 @@ void snapshotState(
&& ((AbstractKeyedStateBackend<?>)
keyedStateBackend)
.requiresLegacySynchronousTimerSnapshots(
checkpointOptions.getCheckpointType());
+ requiresLegacyRawKeyedStateSnapshots |=
+ keyedStateBackend instanceof AsyncKeyedStateBackend
+ && ((AsyncKeyedStateBackend<?>)
keyedStateBackend)
+
.requiresLegacySynchronousTimerSnapshots(
Review Comment:
> How about remove
AsyncKeyedStateBackend#requiresLegacySynchronousTimerSnapshots and do the
following
ForSt state backend may support storing timers in files in the future, so
`requiresLegacySynchronousTimerSnapshots` will return false. I prefer to keep
it as it is.
> should subclasses like AsyncKeyedStateBackendAdaptor override this method?
Good point, we can store timers in the form of `delegated keyed state
backend`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
