Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2781#discussion_r91087691
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1317,9 +1320,13 @@ class JobManager(
log.info(s"Starting job from savepoint '$savepointPath'" +
(if (allowNonRestored) " (allowing non restored state)"
else "") + ".")
- // load the savepoint as a checkpoint into the system
- val savepoint: CompletedCheckpoint =
SavepointLoader.loadAndValidateSavepoint(
- jobId, executionGraph.getAllVertices, savepointPath,
allowNonRestored)
+ // load the savepoint as a checkpoint into the system
+ val savepoint: CompletedCheckpoint =
SavepointLoader.loadAndValidateSavepoint(
+ jobId,
+ executionGraph.getAllVertices,
+ savepointPath,
+ userCodeLoader,
--- End diff --
Minor comment: I think you can grab the user code ClassLoader form the
ExecutionGraph (that allows you to keep the class loader variable final and in
the narrower scope)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
