mateczagany commented on code in PR #896: URL: https://github.com/apache/flink-kubernetes-operator/pull/896#discussion_r1796629815
########## flink-autoscaler/src/test/java/org/apache/flink/autoscaler/RestApiMetricsCollectorTest.java: ########## @@ -44,18 +44,21 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Timeout; +import java.time.Duration; import java.util.HashMap; import java.util.List; import java.util.Map; import java.util.concurrent.CompletableFuture; import java.util.stream.Collectors; +import static org.assertj.core.api.Assertions.assertThat; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.fail; +import static org.testcontainers.shaded.org.awaitility.Awaitility.await; Review Comment: Thank you, just one small thing, can you please also remove it in `flink-kubernetes-operator/pom.xml`? Besides this, all looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
