Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/2810
  
    @tonycox, great. Thanks for the notice! Is the PR ready to review from your 
point of view or are you still working on it?
    
    @KurtYoung Thanks for reaching out to this PR. I'd like to propose the 
following. I'll have a look at both PRs and see how we can maybe split the 
effort into two commits. So, everybody gets a contribution out of this effort.
    
    Regarding making `CsvTableSource` a `ProjectableTableSource`, it is true 
that `CsvTableSource` will not benefit as much as other sources. Even with 
pushed-down projections, it will still read all data and split it into rows. 
However, we can save some time in field parsing (esp. tailing fields are not 
parsed at all) and object creation (and later garbage collection). So, making 
`CsvTableSource` a `ProjectableTableSource` will mainly safe some CPU time and 
not IO. In addition, this is currently the only `BatchTableSource` and rather 
easy to test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to