lvyanquan commented on code in PR #25331:
URL: https://github.com/apache/flink/pull/25331#discussion_r1778809886
##########
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/BatchSink.java:
##########
@@ -73,64 +51,4 @@ public static DataStreamSink<Row> createBatchNoCompactSink(
sink.getTransformation().setParallelism(parallelism,
parallelismConfigured);
return sink;
}
-
- public static <T> DataStreamSink<?> createBatchCompactSink(
Review Comment:
done.
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java:
##########
@@ -281,69 +211,10 @@ protected void submitRequestEntries(
*/
protected abstract long getSizeInBytes(RequestEntryT requestEntry);
- /**
- * This method is deprecated, please use the constructor that specifies
the {@link
- * AsyncSinkWriterConfiguration}.
- */
- @Deprecated
- public AsyncSinkWriter(
- ElementConverter<InputT, RequestEntryT> elementConverter,
- Sink.InitContext context,
- int maxBatchSize,
- int maxInFlightRequests,
- int maxBufferedRequests,
- long maxBatchSizeInBytes,
- long maxTimeInBufferMS,
- long maxRecordSizeInBytes) {
- this(
- elementConverter,
- context,
- maxBatchSize,
- maxInFlightRequests,
- maxBufferedRequests,
- maxBatchSizeInBytes,
- maxTimeInBufferMS,
- maxRecordSizeInBytes,
- Collections.emptyList());
- }
-
- /**
- * This method is deprecated, please use the constructor that specifies
the {@link
- * AsyncSinkWriterConfiguration}.
- */
- @Deprecated
- public AsyncSinkWriter(
- ElementConverter<InputT, RequestEntryT> elementConverter,
- Sink.InitContext context,
- int maxBatchSize,
- int maxInFlightRequests,
- int maxBufferedRequests,
- long maxBatchSizeInBytes,
- long maxTimeInBufferMS,
- long maxRecordSizeInBytes,
- Collection<BufferedRequestState<RequestEntryT>> states) {
- this(
- elementConverter,
- context,
- AsyncSinkWriterConfiguration.builder()
- .setMaxBatchSize(maxBatchSize)
- .setMaxBatchSizeInBytes(maxBatchSizeInBytes)
- .setMaxInFlightRequests(maxInFlightRequests)
- .setMaxBufferedRequests(maxBufferedRequests)
- .setMaxTimeInBufferMS(maxTimeInBufferMS)
- .setMaxRecordSizeInBytes(maxRecordSizeInBytes)
- .build(),
- states);
- }
-
- /**
- * Should be removed along {@link
- * org.apache.flink.api.connector.sink2.StatefulSink.StatefulSinkWriter}.
- */
- @Deprecated
+ /** Should be removed along {@link
org.apache.flink.api.connector.sink2.StatefulSinkWriter}. */
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
