SamBarker commented on PR #881: URL: https://github.com/apache/flink-kubernetes-operator/pull/881#issuecomment-2372924564
> Do you have any recommendation how we should test this and make sure it works? Maybe we can add a case to the e2e-s somehow? Hmm thats a good question. It looks fairly easy to add it to maven build matrix (though at what cost?) and thus test on every build. That is however of debatable value as there is no change to the projects code and thus all it would really be doing is testing a third party dependency and is that very interesting at unit/integration test level? A more interesting angle as suggested is to include it in the e2e suite. Which again has a massive implication for the spread of tests but is probably more interesting as it validates it works against various different minikube setups. I've added both options in different commits so we can easily drop them if they aren't considered helpful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
