jnh5y commented on code in PR #25380:
URL: https://github.com/apache/flink/pull/25380#discussion_r1773603139


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalDeduplicate.scala:
##########
@@ -30,9 +30,10 @@ import org.apache.calcite.rel.{RelNode, RelWriter, SingleRel}
 import java.util
 
 /**
- * Stream physical RelNode which deduplicate on keys and keeps only first row 
or last row. This node
- * is an optimization of [[StreamPhysicalRank]] for some special cases. 
Compared to
- * [[StreamPhysicalRank]], this node could use mini-batch and access less 
state.
+ * TODO to be removed after FLINK-34702 is fixed. Stream physical RelNode 
which deduplicate on keys

Review Comment:
   Since this operator may be used in existing Flink jobs, I do not believe we 
can remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to