codenohup commented on code in PR #25374:
URL: https://github.com/apache/flink/pull/25374#discussion_r1771593354
##########
flink-table/flink-sql-gateway/src/test/resources/log4j2-test.properties:
##########
@@ -18,7 +18,7 @@
# Set root logger level to OFF to not flood build logs
# set manually to INFO for debugging purposes
-rootLogger.level = OFF
+rootLogger.level = INFO
Review Comment:
why?
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SourceNAryInputChainingITCase.java:
##########
@@ -365,7 +365,13 @@ private static JobGraph
sinkAndCompileJobGraph(DataStream<?> stream) {
return StreamingJobGraphGenerator.createJobGraph(streamGraph);
}
- private static void verifySequence(final List<Long> sequence, final long
from, final long to) {
+ private static void verifySequence(
+ final CloseableIterator<Long> iter, final long from, final long
to) {
+ List<Long> sequence = new ArrayList<>();
Review Comment:
It cloud use `org.apache.flink.util.CollectionUtil#iteratorToList`
##########
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/IntervalJoinITCase.java:
##########
@@ -361,6 +362,7 @@ public void testBoundsAreInclusiveByDefault() throws
Exception {
DataStream<Tuple2<String, Integer>> streamOne =
env.fromData(Tuple2.of("key", 0), Tuple2.of("key", 1),
Tuple2.of("key", 2))
+
.assignTimestampsAndWatermarks(WatermarkStrategy.forMonotonousTimestamps())
Review Comment:
Why are there two _assignTimestampsAndWatermarks_ calls? The fist call may
lack a _TimestampAssigner_, while the second call could potentially override
the _WatermarkStrategy_ setted by the first.
##########
flink-table/flink-sql-gateway/pom.xml:
##########
@@ -51,6 +51,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
Review Comment:
why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
