zhuzhurk commented on code in PR #25352: URL: https://github.com/apache/flink/pull/25352#discussion_r1768319833
########## flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogStateBackendLoadingTest.java: ########## @@ -219,29 +218,14 @@ public void testLoadingRocksDBStateBackend() throws Exception { @Test public void testEnableChangelogStateBackendInStreamExecutionEnvironment() throws Exception { StreamExecutionEnvironment env = getEnvironment(); - assertStateBackendAndChangelogInEnvironmentAndStreamGraphAndJobGraph( - env, TernaryBoolean.UNDEFINED, null); + assertStateBackendAndChangelogInStreamGraphAndJobGraph(env, TernaryBoolean.UNDEFINED); // set back and force - env.setStateBackend(new MemoryStateBackend()); - assertTrue(env.getStateBackend() instanceof MemoryStateBackend); - assertStateBackendAndChangelogInEnvironmentAndStreamGraphAndJobGraph( - env, TernaryBoolean.UNDEFINED, MemoryStateBackend.class); + assertStateBackendAndChangelogInStreamGraphAndJobGraph(env, TernaryBoolean.UNDEFINED); Review Comment: I think this verification is no longer needed because it is not set back and forth. So is the comment above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org