venkata91 commented on PR #24736:
URL: https://github.com/apache/flink/pull/24736#issuecomment-2367194478

   @JunRuiLee First of all, apologies for very late reply!
   
   I think the issue is, if source parallelism is not explicitly set and if 
`execution.batch.adaptive.auto-parallelism.max-parallelism` is set < 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism` then the 
source vertex max parallelism is set to the value of 
`execution.batch.adaptive.auto-parallelism.max-parallelism`.
   
   > My point is that the upper bound returned by 
computeSourceParallelismUpperBound should be the minimum of 
execution.batch.adaptive.auto-parallelism.default-source-parallelism and the 
maximum parallelism of the JobVertex itself
   
   If the above happens, then we will back to square 1 where the source 
parallelism is bounded by 
`execution.batch.adaptive.auto-parallelism.max-parallelism` even if 
`execution.batch.adaptive.auto-parallelism.default-source-parallelism` set 
greater than that.
   
   Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to