fredia commented on code in PR #25367:
URL: https://github.com/apache/flink/pull/25367#discussion_r1770726474
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##########
@@ -189,6 +194,9 @@ public RecordContext<K> buildContext(Object record, K key) {
*/
public void setCurrentContext(RecordContext<K> switchingContext) {
currentContext = switchingContext;
+ if (switchContextListener != null) {
Review Comment:
When will be `switchContextListener` be null?
This is on the critical path, is it okay not to check for null?
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/AbstractKeyedStateBackend.java:
##########
@@ -250,6 +250,13 @@ public void setCurrentKey(K newKey) {
KeyGroupRangeAssignment.assignToKeyGroup(newKey,
numberOfKeyGroups));
}
+ /** Only used in {@code AsyncKeyedStateBackendAdaptor}. */
+ public void setCurrentKeyAndKeyGroupIndex(K newKey, int newKeyGroupIndex) {
Review Comment:
Can we add `setCurrentKeyAndKeyGroupIndex` to `KeyedStateBackend` interface?
nit: let `setCurrentKey` use the common part of
`setCurrentKeyAndKeyGroupIndex` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
