[
https://issues.apache.org/jira/browse/FLINK-5261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15722283#comment-15722283
]
ASF GitHub Bot commented on FLINK-5261:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2944#discussion_r90864551
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/main/java/org/apache/flink/dropwizard/ScheduledDropwizardReporter.java
---
@@ -91,6 +91,10 @@ protected ScheduledDropwizardReporter() {
return meters;
}
+ Map<Gauge<?>, String> getGauges() { return gauges; }
--- End diff --
Can you do a new line for the return and add a annotation like
`@VisibleForTesting`?
> ScheduledDropwizardReporter does not properly clean up metrics
> --------------------------------------------------------------
>
> Key: FLINK-5261
> URL: https://issues.apache.org/jira/browse/FLINK-5261
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.2.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.2.0
>
>
> The ScheduleDropWizardReporter does not have a separate branch for meters in
> notifyOfRemovedMetric.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
