Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2944#discussion_r90864749
  
    --- Diff: 
flink-metrics/flink-metrics-dropwizard/src/test/java/org/apache/flink/dropwizard/ScheduledDropwizardReporterTest.java
 ---
    @@ -124,6 +129,89 @@ public void testAddingMetrics() throws 
NoSuchFieldException, IllegalAccessExcept
                metricRegistry.shutdown();
        }
     
    +   @Test
    --- End diff --
    
    Can you add a high level description about what this test does please? 
Otherwise this looks good. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to