liangyu-1 commented on PR #25226: URL: https://github.com/apache/flink/pull/25226#issuecomment-2359924470
> @liangyu-1 Thanks for addressing my comments. I think the PR is very close to a mergable state. I left only one minor inline comment. In addition, the CI is failing due to the usage of Mockito. I personally would be fine with using Mockito in this case. In order to fix the CI, I think we need to append the file that imports Mockito to the suppress file list for the IllegalImport check in `tools/maven/suppressions.xml`. @xintongsong Thanks for the suggestion, I am sorry that I didn't notice this before. I have just changed file `suppressions.xml` and it should be ok this time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
