karubian commented on code in PR #150:
URL:
https://github.com/apache/flink-connector-aws/pull/150#discussion_r1758962947
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java:
##########
@@ -226,4 +249,37 @@ public UserCodeClassLoader getUserCodeClassLoader() {
}
});
}
+
+ private RetryStrategy createExpBackoffRetryStrategy(
+ Duration initialDelay, Duration maxDelay, int maxAttempts) {
+ final BackoffStrategy backoffStrategy =
+ BackoffStrategy.exponentialDelayHalfJitter(initialDelay,
maxDelay);
+
+ return StandardRetryStrategy.builder()
+ .backoffStrategy(backoffStrategy)
+ .throttlingBackoffStrategy(backoffStrategy)
Review Comment:
We can use but the difference looks marginal.
Difference between these is the defaults for the attributes below:
` .maxAttempts(DefaultRetryStrategy.Standard.MAX_ATTEMPTS)
.tokenBucketStore(TokenBucketStore
.builder()
.tokenBucketMaxCapacity(DefaultRetryStrategy.Standard.TOKEN_BUCKET_SIZE)
.build())
.tokenBucketExceptionCost(DefaultRetryStrategy.Standard.DEFAULT_EXCEPTION_TOKEN_COST);`
We are not overriding token bucket store and cost at the moment.
Also, the Standard one is public API and the other one is internal API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
